You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only allows orgs with organization.flags.allow_joinleave set to true to use Seer Explorer. This is because Explorer requires aggregating context across all projects, which violates permissions if some members aren't allowed to access some projects.
Restrict Seer Explorer Access to Organizations With Open Membership
This pull request enforces that only organizations with organization.flags.allow_joinleave set to true (i.e., open team membership) are permitted to access the Seer Explorer feature. This change is introduced to prevent permission violations that could occur when Seer Explorer aggregates context across projects, as closed team membership could involve restricted access. The implementation updates both the endpoint logic to add the necessary restriction checks and the associated tests to ensure correct permission handling and error messaging.
Key Changes
• Added checks in OrganizationSeerExplorerChatEndpoint (src/sentry/seer/endpoints/organization_seer_explorer_chat.py) to return a 403 response if organization.flags.allow_joinleave is false on both GET and POST methods.
• Updated error messages to clearly state that Seer Explorer requires open team membership.
• Introduced new test cases in tests/sentry/seer/endpoints/test_organization_seer_explorer_chat.py to verify correct 403 responses and messaging when open membership is disabled.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only allows orgs with
organization.flags.allow_joinleaveset to true to use Seer Explorer. This is because Explorer requires aggregating context across all projects, which violates permissions if some members aren't allowed to access some projects.Copied from getsentry#101178
Original PR: getsentry#101178